Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test rate-limits branch #33

Closed
wants to merge 8 commits into from
Closed

test rate-limits branch #33

wants to merge 8 commits into from

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Mar 5, 2024

just to check for any regressions

Copy link

github-actions bot commented Mar 5, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted
  • src/demo.cpp
  • src/demo.hpp
clang-tidy reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

@2bndy5 2bndy5 marked this pull request as ready for review March 5, 2024 13:09
github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review March 5, 2024 13:31

outdated suggestion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +17,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..115b0de 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Have any feedback or feature suggestions? Share it here.

src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.hpp Show resolved Hide resolved
src/demo.hpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
@2bndy5 2bndy5 closed this Mar 5, 2024
@2bndy5 2bndy5 deleted the test-pr-reviews branch March 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant